Skip to content

ci: Fix zizmor warnings and bump actions - #22

Merged
Techassi merged 7 commits into
stackabletech:mainfrom
Saul-STFC:CI-Hardening
Sep 1, 2026
Merged

ci: Fix zizmor warnings and bump actions#22
Techassi merged 7 commits into
stackabletech:mainfrom
Saul-STFC:CI-Hardening

Conversation

@Saul-STFC

Copy link
Copy Markdown
Contributor

No description provided.

@Techassi Techassi moved this to Development: In Review in Stackable Engineering Aug 31, 2026
Techassi
Techassi previously approved these changes Aug 31, 2026

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just two small comments.

Comment thread .github/workflows/pr_pre-commit.yaml Outdated
Comment thread .github/workflows/build.yaml Outdated
@Techassi Techassi changed the title CI: Fix zizmor warnings and bump deps ci: Fix zizmor warnings and bump actions Aug 31, 2026
@Saul-STFC

Copy link
Copy Markdown
Contributor Author

Fixed precommit warnings on #ec881447a

Techassi
Techassi previously approved these changes Sep 1, 2026

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

CC'ing @dervoeti for a second pair of eyes.

Comment thread .github/workflows/security_audit.yaml Outdated
dervoeti
dervoeti previously approved these changes Sep 1, 2026

@dervoeti dervoeti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Techassi Just one optional improvement, rest LGTM

Co-authored-by: Lukas Krug <lukas@luvosys.de>
@Techassi
Techassi dismissed stale reviews from dervoeti and themself via cc20ba4 September 1, 2026 10:23
@Techassi
Techassi added this pull request to the merge queue Sep 1, 2026
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Sep 1, 2026
Merged via the queue into stackabletech:main with commit 49f9e27 Sep 1, 2026
5 checks passed
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants